multimedia/gpac-libgpac fails with zlib problem on -current

[Doug Barton]

I'm running today's -current r206052 which includes the latest zlib
update. I'm getting the following error. I tried rebuilding libxml2 just
in case, didn't help.


Doug


cc -O3 -pipe -g -I/usr/local/include -g -fno-strict-aliasing
-Wno-pointer-sign
-I/usr/local/tmp/usr/local/ports/multimedia/gpac-libgpac/work/gpac/include
-I../ -DGPAC_HAVE_CONFIG_H -c -o utils/xml_parser.o utils/xml_parser.c
In file included from /usr/include/zlib.h:34,
from utils/xml_parser.c:30:
/usr/include/zconf.h:367:53: error: operator '||' has no right operand
In file included from utils/xml_parser.c:30:
/usr/include/zlib.h:1559:25: error: operator '==' has no left operand
gmake: *** [utils/xml_parser.o] Error 1
*** Error code 1

Stop in /usr/local/ports/multimedia/gpac-libgpac.
*** Error code 1

[Xin LI]

Post by Doug Barton
I'm running today's -current r206052 which includes the latest zlib
update. I'm getting the following error. I tried rebuilding libxml2 just
in case, didn't help.

Sorry it's a regression I think. zlib is trying to enforce too strict
check which I didn't found a clue at e.g. glibc's manual, I'll post a
patch to fix this issue.

In the meantime I think the attached patch (zlib-freebsd.diff) would fix
this exact problem. I'll send the zlib.diff for upstream's review.

Post by Doug Barton
cc -O3 -pipe -g -I/usr/local/include -g -fno-strict-aliasing
-Wno-pointer-sign
-I/usr/local/tmp/usr/local/ports/multimedia/gpac-libgpac/work/gpac/include
-I../ -DGPAC_HAVE_CONFIG_H -c -o utils/xml_parser.o utils/xml_parser.c
In file included from /usr/include/zlib.h:34,
/usr/include/zconf.h:367:53: error: operator '||' has no right operand
/usr/include/zlib.h:1559:25: error: operator '==' has no left operand
gmake: *** [utils/xml_parser.o] Error 1
*** Error code 1
Stop in /usr/local/ports/multimedia/gpac-libgpac.
*** Error code 1

- --
Xin LI <***@delphij.net> http://www.delphij.net/
FreeBSD - The Power to Serve! Live free or die

[Xin LI]

Hi,

In order to prevent further damage, I have hardcoded FreeBSD's
configuration as unifdef'ed in zlib.h:

-D_FILE_OFFSET_BITS=64 -U_LFS64_LARGEFILE -U_LARGEFILE64_SOURCE

Hope this helps. I'm still in discussion with upstream author about a
better solution.

Cheers,
- --
Xin LI <***@delphij.net> http://www.delphij.net/
FreeBSD - The Power to Serve! Live free or die

[Doug Barton]

Post by Xin LI
Hi,
In order to prevent further damage, I have hardcoded FreeBSD's
-D_FILE_OFFSET_BITS=64 -U_LFS64_LARGEFILE -U_LARGEFILE64_SOURCE
Hope this helps. I'm still in discussion with upstream author about a
better solution.

Unfortunately, even with your latest change I'm still getting the
following error:

cc -O3 -pipe -g -I/usr/local/include -g -fno-strict-aliasing
-Wno-pointer-sign
-I/usr/local/tmp/usr/local/ports/multimedia/gpac-libgpac/work/gpac/include
-I../ -DGPAC_HAVE_CONFIG_H -c -o utils/xml_parser.o utils/xml_parser.c
In file included from /usr/include/zlib.h:34,
from utils/xml_parser.c:30:
/usr/include/zconf.h:367:53: error: operator '||' has no right operand
gmake: *** [utils/xml_parser.o] Error 1
*** Error code 1

[Doug Barton]

Post by Xin LI
Hi,
In order to prevent further damage, I have hardcoded FreeBSD's
-D_FILE_OFFSET_BITS=64 -U_LFS64_LARGEFILE -U_LARGEFILE64_SOURCE
Hope this helps.

Woo hoo! r206058 has done the trick. :)


Thanks,

Doug